This repository was archived by the owner on Apr 11, 2024. It is now read-only.
test name if it's still null, default node.js #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test for versions for 'nw' doesn't have a default case if versions is an object, but does not have 'nw'
|
Actually this does work; my testing had mixed versions. |
|
Any progress on this? |
|
Thanks @d3x0r! |
|
someone else ran into this problem; I thought this was merged... but looking at the code it's still not there actually. And I didn't see the merge in the revision history of the project.... did you do something like merge it to close it and shut me up then delete the merge? (sorry I"m cynical) |
|
I think the version was not bumped yet |
jdalton
pushed a commit
that referenced
this pull request
Jun 13, 2017
The new test for versions for 'nw' doesn't have a default case if versions is an object, but does not have 'nw'
pubkey
added a commit
to pubkey/rxdb
that referenced
this pull request
Jul 18, 2017
bnjmnt4n
added a commit
that referenced
this pull request
Dec 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test for versions for 'nw' doesn't have a default case if versions is an object, but does not have 'nw'
should fix #125
Making PR to test; will update comment after.