Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the OXID stack is available for the metadata file #114

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

GM-Alex
Copy link
Contributor

@GM-Alex GM-Alex commented Oct 7, 2019

Ensures that the OXID stack is available before we run additional actions on the metadata file. If the stack is not available and the file gets processed all entries are set up for OXID 6.2 and we are also fine.

@GM-Alex GM-Alex force-pushed the feature/composer-install-adjustments branch from aabc8b9 to 940b387 Compare October 7, 2019 19:03
@GM-Alex GM-Alex force-pushed the feature/composer-install-adjustments branch from 940b387 to 7a65714 Compare October 8, 2019 08:22
Copy link
Contributor

@b3nl b3nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input. The metadata looks - not tested - fine for me. But what are the queries for?

tests/acceptance/FrontendTest.php Show resolved Hide resolved
Copy link
Contributor

@b3nl b3nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Oversaw that the queries are in a test.

@b3nl b3nl merged commit 9020c18 into bestit:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants