Skip to content

Commit

Permalink
Remove submit on close from RT 5 datepicker
Browse files Browse the repository at this point in the history
In RT 5, the date picker had a Done button and date
changes were automatically submitted when done was
clicked. The new date picker has an X rather than
Done, so it's not clear that clicking that will not
only close the picker, but submit the value. Users may
want to check and edit the value before submitting, so the
auto-submit may be surprising. Remove the non-functioning
auto-submit code for now rather than updating it to trigger
on the X click.

Users can still select a value and click the green checkmark
directly.
  • Loading branch information
cbrandtbuffalo committed Feb 28, 2025
1 parent f16a2e7 commit b119106
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions share/static/js/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -2024,10 +2024,6 @@ jQuery(function () {
jQuery(document).on('change', 'div.editable.editing form select', function () {
submitInlineEdit(jQuery(this).closest('form'));
});

jQuery(document).on('datepicker:close', 'div.editable.editing form .datepicker', function () {
submitInlineEdit(jQuery(this).closest('form'));
});
});

function loadOwnerDropdownDelay(owner_dropdown_delay) {
Expand Down

0 comments on commit b119106

Please sign in to comment.