Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cordova framework to build Android app #1946
Cordova framework to build Android app #1946
Changes from all commits
4f93e54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick - this does not seem to be true any more - probably rather 'or Android platform, dist task will generate folders and files in the
./cordova
folder'.A cleaner way to do this would be to have these files generated under
/dist
or/cordova-dist
, but not sure if this is possible in an easy way with Cordova.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rename the
cordova
folder tocordova-dist
. But I think, there is a risk of confusion, the equivalent of thedist
folder in the cordova project is morecordova/src
. Moreover, thecordova
folder can not be deleted like thedist
folderThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the problem is that the statement 'For Android platform, dist task will generate the
./cordova
folder' will make people think that this directory can be deleted when cleaning up after a build. Another problem is thatyarn gulp clean
currently fails to remove build artefacts in/cordova
- the easiest solution for this will be to separate the files that currently end up under/cordova
into two different directories: One for the permanent files, another one (which can be a sub-directory) for the build artefacts. This will also make fixingyarn gulp clean
a lot easier.But this can all be done in a follow-up pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WalcoFPV: I think this needs to be fixed with some urgency, and it is a little bit more complex than previously thought:
Since a build of the Android app modifies some files that are under source control (
cordova/config.xml
,cordova/config.xml
) these will appear as changed and sneak into subsequent commits for unrelated changes:This is a hassle and will require a lot of manual cleanup in the future, so it should be fixed - probably best rename the files to
..._template
or suchlike, and create a copy of them in the directory that is to contain the build artefacts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ! #2109