Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated builds for maintenance branches. #2354

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

mikeller
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

- master
- "*-maintenance"
- master
- "*-maintenance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is working, but the correct way is indenting with two spaces the list inside the group? At least is how I used it until now but I'm not a Yaml expert...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither - the rest of azure-pipelines.yml seems to be placing list elements on the same level as the list name, so this is just making the files consistent.
If it is wrong it should be amended for the entire file in a separate pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some tests in some online yaml validators, and it seems they accept both forms, so this seems ok...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, YAML is a lot like JS - unless it's obviously wrong it's assumed to be right.

@mikeller mikeller merged commit 6110137 into betaflight:master Dec 22, 2020
@mikeller mikeller deleted the add_maintenance_builds branch December 22, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants