Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix motor stop #2970

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Fix motor stop #2970

merged 1 commit into from
Jul 24, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 8, 2022 •
edited
Loading

  • Disabling motor testing and returning to the motors tab will re-enable testing.
  • Resetting status polling to run all the time instead of just during engine testing fixes this bug.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jul 8, 2022
@haslinghuis haslinghuis self-assigned this Jul 8, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jul 9, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
asizon
asizon previously approved these changes Jul 15, 2022
View reviewed changes
chmelevskij
chmelevskij previously approved these changes Jul 19, 2022
View reviewed changes
@haslinghuis haslinghuis requested a review from McGiverGim July 19, 2022 22:22
@haslinghuis haslinghuis mentioned this pull request Jul 22, 2022
Merged
@haslinghuis haslinghuis dismissed stale reviews from chmelevskij and asizon via 48743a8 July 23, 2022 14:58
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Fix motor stop Fix motor stop and enable extended dshot telemetry Jul 23, 2022
@haslinghuis haslinghuis changed the title Fix motor stop and enable extended dshot telemetry Fix motor stop Jul 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit 1c77543 into betaflight:master Jul 24, 2022
@haslinghuis haslinghuis deleted the fix-motor-stop branch July 24, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@chmelevskij chmelevskij chmelevskij left review comments

@asizon asizon asizon left review comments

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @limonspb @chmelevskij @asizon