Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some absence of port selection menu #3015

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix some absence of port selection menu #3015

merged 1 commit into from
Oct 17, 2022

Conversation

ASDosjani
Copy link
Contributor

@ASDosjani ASDosjani commented Sep 1, 2022 •
edited
Loading

I made a fix for virtual connection and show all serial device so there is no need to restart the configurator if you change these settings from now.

@blckmn
Copy link
Member

blckmn commented Sep 1, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
McGiverGim
McGiverGim previously approved these changes Sep 21, 2022
View reviewed changes
limonspb
limonspb previously approved these changes Sep 22, 2022
View reviewed changes
@ASDosjani ASDosjani dismissed stale reviews from limonspb and McGiverGim via 2d027af September 22, 2022 12:39
@McGiverGim
Copy link
Member

You don't have to merge master into your branch. To put your branch up to date, you must rebase master onto your branch and after that do a push with --force-with-lease

@ASDosjani ASDosjani force-pushed the port_fix branch 5 times, most recently from afba60b to d44f91d Compare September 22, 2022 14:54
@haslinghuis
Copy link
Member

Please also verify ELRS wifi is still working.

@ASDosjani
Copy link
Contributor Author

ASDosjani commented Sep 22, 2022 •
edited
Loading

Please also verify ELRS wifi is still working.

It's working, only the auto mdns search is broken. It's shows up for a few seconds but than it dissapeare. It has the same behavior in the latest nightly build so it's not related to my code.

haslinghuis
haslinghuis reviewed Sep 23, 2022
View reviewed changes
src/js/port_handler.js Outdated Show resolved Hide resolved
haslinghuis
haslinghuis reviewed Sep 23, 2022
View reviewed changes
src/js/port_handler.js Outdated Show resolved Hide resolved
@ASDosjani ASDosjani force-pushed the port_fix branch 2 times, most recently from f326f27 to e4e08fa Compare September 23, 2022 08:53
haslinghuis
haslinghuis requested changes Sep 23, 2022
View reviewed changes
src/js/tabs/firmware_flasher.js Outdated Show resolved Hide resolved
src/js/port_handler.js Outdated Show resolved Hide resolved
src/js/port_handler.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.9.0 milestone Sep 23, 2022
haslinghuis
haslinghuis requested changes Sep 28, 2022
View reviewed changes
src/js/port_handler.js Outdated Show resolved Hide resolved
@ASDosjani ASDosjani requested review from haslinghuis and removed request for McGiverGim September 29, 2022 10:37
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis previously approved these changes Sep 29, 2022
View reviewed changes
McGiverGim
McGiverGim previously approved these changes Sep 29, 2022
View reviewed changes
@ASDosjani ASDosjani requested a review from limonspb September 29, 2022 11:34
@ASDosjani ASDosjani dismissed stale reviews from McGiverGim and haslinghuis via 6cffcf6 October 15, 2022 09:14
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis previously approved these changes Oct 16, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ASDosjani
Copy link
Contributor Author

ASDosjani commented Oct 16, 2022 •
edited
Loading

I changed the timeout clearing. Can you guys check?

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit 00ecf2b into betaflight:master Oct 17, 2022
@ASDosjani ASDosjani deleted the port_fix branch June 11, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@ASDosjani ASDosjani

Labels
Ready to Merge RN: IMPROVEMENT Tested
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ASDosjani @blckmn @McGiverGim @haslinghuis @limonspb