Add center crosshair to the OSD helper lines #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
McGiverGim
force-pushed
the
cross_center_osd
branch
from
7a1a33b to
eddf017
Compare
|
Pushed a change to disable the pointer events over the crosshair. They were interfering with the drag and drop of the OSD elements. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Jan 13, 2023
|
AUTOMERGE: (FAIL)
|
blckmn
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help centering elements, this PR adds a crosshair in the center of the OSD when moving elements:
I have added it with CSS only, maybe is better to use some SVG or similar, but for a first version is enough. After feedback from users, maybe is better to add some vertical/horizontal lines too to help with the border elements.