Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop jquery debounce for local implementation #3296

Merged

Conversation

chmelevskij
Copy link
Member

Drop minimized jquery debounc library from libraries in favour of local implementation

@McGiverGim
Copy link
Member

What fixes this? A little of more background will be great.

@blckmn
Copy link
Member

blckmn commented Jan 30, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added dependencies Pull requests that update a dependency file RN: REFACTOR labels Jan 30, 2023
@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 30, 2023
@chmelevskij
Copy link
Member Author

@McGiverGim I've started into looking running configurator in the browser. jquery has bunch of plugins which expect different global variables to exist and when using modules and this was throwing jQuery is not defined.

This could be as easily replaced with something more solid like lodash.debounce, or what I've done since it's non-trivial thing to implement.

@McGiverGim
Copy link
Member

Ok. I wanted to know the reason, is good to have it explained at the text of the PR, to anyone that wants to consult it.
My personal preference is to have always something extern to have less code to maintain, but it's ok both ways.

@blckmn
Copy link
Member

blckmn commented Jan 30, 2023

Failing on account of the missing LF at the EOF.

@chmelevskij
Copy link
Member Author

@McGiverGim ba-throttle is actually stored as minified file in this repository, so it's worst of both worlds 😄 Technically we maintain it and it's minified so it's not even possible to fix it.

@chmelevskij chmelevskij force-pushed the chore/remove-throttle-debounce-dep branch from 53e34f7 to b14b811 Compare January 31, 2023 07:46
@chmelevskij
Copy link
Member Author

Replaced handrolled debounce with lodash.debounce now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit d899009 into betaflight:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file RN: REFACTOR
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants