-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latest version check #3349
Fix latest version check #3349
Conversation
This comment has been minimized.
This comment has been minimized.
It references your configurator version. ie your version is current |
AUTOMERGE: (FAIL)
|
cb2d217
to
c4a688f
Compare
This comment has been minimized.
This comment has been minimized.
@haslinghuis the intention is that the API assesses your configurator version and returns isCurrent or not. Whether the API gets it right or not at the moment is not important, as that can change without the release of a configurator. So you don't need the debug check. |
c85b12f
to
927b2e1
Compare
Kudos, SonarCloud Quality Gate passed!
|
Do you want to test this code? Here you have an automated build: |
@blckmn
Maybe it failed because using debug version otherwise assume API works as:
isCurrent
= true when type = stable;isCurrent
= true irrespective of type as long there is no 10.10.0RC1Using
10.10
without checking unstable versions: