Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest version check #3349

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Feb 19, 2023

@blckmn

Maybe it failed because using debug version otherwise assume API works as:

  • 10.9 should return isCurrent = true when type = stable;
  • 10.10 should return isCurrent = true irrespective of type as long there is no 10.10.0RC1

Using 10.10 without checking unstable versions:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 19, 2023
@haslinghuis haslinghuis self-assigned this Feb 19, 2023
@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Feb 19, 2023

It references your configurator version. ie your version is current

@blckmn
Copy link
Member

blckmn commented Feb 20, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis force-pushed the fix-latestversion-check branch from cb2d217 to c4a688f Compare February 20, 2023 00:56
@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Feb 20, 2023

@haslinghuis the intention is that the API assesses your configurator version and returns isCurrent or not.

Whether the API gets it right or not at the moment is not important, as that can change without the release of a configurator.

So you don't need the debug check.

@haslinghuis haslinghuis force-pushed the fix-latestversion-check branch from c85b12f to 927b2e1 Compare February 21, 2023 00:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit 4b9fab6 into betaflight:master Feb 22, 2023
@haslinghuis haslinghuis deleted the fix-latestversion-check branch February 22, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

2 participants