-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPS icon now reflect fix state #3377
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
@haslinghuis, nice suggestion, code moved to sensor_helpers.js |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
048d6ef
to
1513f19
Compare
Kudos, SonarCloud Quality Gate passed!
|
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- looks good. i cannot test, however.
i saw this (via email), so i removed my approval but then i mistakenly thought it was already done (when viewing github.com), so re-applied my approval. then it was merged. i think @HThuren wanted to change something before merging. |
All good. Conversation was resolved by @HThuren - we can always make a patch if needed. |
I was done, nice to have the merge :-) |
hi @bact2828, the state in use are from FC, ie. FC.GPS_DATA.fix. Same status as in GPS tab: |
GPS icon change when fixed. Start with Red = GPS configured, but no fix, change to Yellow when fix are reached.
GPS not fixed

GPS fixed
