Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help to modes at Mode tab #3430

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Add help to modes at Mode tab #3430

merged 2 commits into from
Apr 27, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Apr 23, 2023

This PR add help to Betaflight modes.
When new to Betaflight, you spend many hours to understand the modes, here are some help to reduce that time.
Help text come from betaflight.com where present.
image

@github-actions

This comment has been minimized.

Sign in to view
@HThuren HThuren changed the title Add help to modes Add help to modes at Mode tab Apr 23, 2023
@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 23, 2023
haslinghuis
haslinghuis approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@blckmn
Copy link
Member

blckmn commented Apr 23, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I didn't know we don't have a description for this.
Only two suggestions, but are not mandatory, only my opinion.

src/js/tabs/auxiliary.js Outdated Show resolved Hide resolved
locales/en/messages.json Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 51af4da into betaflight:master Apr 27, 2023
@HThuren HThuren deleted the addHelpForModes branch April 27, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @McGiverGim @haslinghuis