-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sponsor tile to firmware flashing tab #3468
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
This comment has been minimized.
This comment has been minimized.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
I can see the window for the sponser bar.. what do we need to do to get it working @blckmn |
Some html tidy up :) possibly detection between dark and light mode... not sure if we should do that in the app or API... |
@blckmn @haslinghuis I don't think this was intentional. Can someone please change this. |
Why did you guys just approve and merge the PR? Guys, please think and check before you approve. The PR wasn't even ready yet but you approved and merged immediately 😅 |
working now ... thx @haslinghuis |
Still need to finalise the Html:
Note the above is independent of this PR (as it is loaded into the API).