Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VTX ready status #3538

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Fix VTX ready status #3538

merged 4 commits into from
Aug 2, 2023

Conversation

haslinghuis
Copy link
Member

Status was no longer retrieved after saving

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 1, 2023
@haslinghuis haslinghuis self-assigned this Aug 1, 2023
@github-actions

This comment has been minimized.

Sign in to view
@HThuren
Copy link
Member

HThuren commented Aug 1, 2023

Great, thank you :-)

@haslinghuis haslinghuis requested a review from ctzsnooze August 1, 2023 18:41
@blckmn
Copy link
Member

blckmn commented Aug 1, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis requested a review from nerdCopter August 2, 2023 16:53
@nerdCopter
Copy link
Member

when False, still green

@nerdCopter
Copy link
Member

briefly still green while temporarily false, when saving already good config
https://youtu.be/p7bcBMJc8B0
a229baa9

@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member Author

Last commit removes initial status, so on save it it does not flip.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 26e78ed into betaflight:master Aug 2, 2023
@haslinghuis haslinghuis deleted the fix-vtx-ready-status branch August 2, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @HThuren @blckmn @nerdCopter @McGiverGim