Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate hardware status info #3650

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Translate hardware status info #3650

merged 2 commits into from
Nov 30, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Nov 29, 2023 •
edited
Loading

Translate hardware status info, reorder a bit
image

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 30, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

haslinghuis commented Nov 30, 2023 •
edited
Loading

@HThuren please change the order of mag and baro to be the same as the order of the icons.

Maybe also rename Acc to Accel.

Disabled by user covers disabled in configuration tab or not powered up states but currently we cannot distinguish between the two, so maybe we rename it to Not detected.

Thoughts?

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 30, 2023
@HThuren
Copy link
Member Author

HThuren commented Nov 30, 2023

@HThuren please change the order of mag and baro to be the same as the order of the icons.

Maybe also rename Acc to Accel.

Disabled by user covers disabled in configuration tab or not powered up states but currently we cannot distinguish between the two, so maybe we rename it to Not detected.

Thoughts?
reordered and acc changed

Not detected maybe changed to Not configured , I planned the last in my translation, what do you think ?

@haslinghuis
Copy link
Member

On my board I need lipo to power some sensors and would show Not configured otherwise.

Not detected is more neutral imho then Disabled by user

@HThuren
Copy link
Member Author

HThuren commented Nov 30, 2023

what about the order of info, change to Instruments, System info, Sensor info, GPS, Sonar, Firmware info ?

@haslinghuis
Copy link
Member

No change needed in order of the panel afaik.

@HThuren
Copy link
Member Author

HThuren commented Nov 30, 2023

Here we go

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested. code looks good by eye.

@haslinghuis haslinghuis merged commit 3822cf2 into betaflight:master Nov 30, 2023
@HThuren HThuren deleted the localeSetupTab branch November 30, 2023 20:53
@haslinghuis
Copy link
Member

Thanks!

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@HThuren @chmelevskij
Translate hardware status info (betaflight#3650)
e2dedb1 
* Translate hardware status info

* Minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@HThuren HThuren

Labels
RN: TRANSLATION RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @haslinghuis @nerdCopter