Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add satellite layer and show map on latlon values #3685

Merged
merged 13 commits into from
Dec 23, 2023
Merged

Add satellite layer and show map on latlon values #3685

merged 13 commits into from
Dec 23, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 20, 2023 •
edited
Loading

  • show gps map whenever we get lat lon values instead of waiting for gps fix
  • add satellite and hybrid layers.
  • satellite layer is default now
  • tag and help icon in image below is now removed as anyone should be familiar using maps.

ROAD:
image

SATELLITE:
image

HYBRID:
image

@haslinghuis haslinghuis self-assigned this Dec 20, 2023
@haslinghuis haslinghuis marked this pull request as draft December 20, 2023 22:42
@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 20, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ctzsnooze
Copy link
Member

This is really cool! Can't wait for it to be working properly!
At the moment I get the satellite map, and that's fantastic!
Only a couple of things to be fixed...

  • clicking the buttons doesn't update the map mode
  • zooming in on the Sat map appears to zoom in on the first image we get, so it gets a but blurry as I zoom in. The image itself isn't updated, I think, by the Maps API, when we zoom in.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as ready for review December 22, 2023 18:10
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
chmelevskij
chmelevskij reviewed Dec 22, 2023
View reviewed changes
src/tabs/gps.html Outdated Show resolved Hide resolved
chmelevskij
chmelevskij reviewed Dec 22, 2023
View reviewed changes
src/js/tabs/map.js Outdated Show resolved Hide resolved
@haslinghuis haslinghuis requested review from asizon and blckmn December 22, 2023 18:58
@blckmn
Copy link
Member

blckmn commented Dec 22, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ctzsnooze
Copy link
Member

This is absolutely fantastic! Great job @haslinghuis

Satellite image shows every detail and makes it really easy to see the amount of wandering around as the sat fix gets better over time.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit fb8b32a into betaflight:master Dec 23, 2023
8 checks passed
@haslinghuis haslinghuis deleted the add-satellite-layer branch December 23, 2023 12:14
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Add satellite layer and show map on latlon values (betaflight#3685)
d72b42a 
* Add satellite layer and show map on latlon values

* Use controls

* Hide all layers initially except OSM

* Remove debug location

* Add some layer tag and update switching

* Remove debug

* Remove layerGroup

* Remove commented code

* Remove maxzoom

* Remove bloat and increase default zoom level

* Use buttons instead of anchors

* Remove class

* Remove unused messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

@asizon asizon Awaiting requested review from asizon

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: IMPROVEMENT Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @ctzsnooze @blckmn @chmelevskij