Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved build request management #3736

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Improved build request management #3736

merged 3 commits into from
Jan 10, 2024

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 7, 2024

Enabling user to cancel and indicating whether actual build processing has commenced or not.

@blckmn blckmn self-assigned this Jan 7, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 7, 2024
@blckmn
Copy link
Member Author

blckmn commented Jan 7, 2024 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

haslinghuis
haslinghuis approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

It is not needed to change other languages then EN.

@McGiverGim has more detail on this. IIRC workflow will invalidate language in Crowdin.

@McGiverGim
Copy link
Member

Exactly, all the languages files will be replaced by the files downloaded from Crowdin. There is not inverse synchronization in our workflow.

@blckmn
Copy link
Member Author

blckmn commented Jan 7, 2024

It was more to have it as completed as possible for any RC inclusion... if we don't include it for RC2 then all good.

@nerdCopter
Copy link
Member

nerdCopter commented Jan 8, 2024 •
edited
Loading

image
image

Seems to "cancel" the UI only, as the API building seems to continue to build. Click log immediately for empty log. Wait a few seconds then refresh log will show succeeded.

@blckmn blckmn merged commit 2fc6465 into betaflight:master Jan 10, 2024
7 of 8 checks passed
@blckmn blckmn deleted the build-patch branch January 10, 2024 20:56
@blckmn
Copy link
Member Author

blckmn commented Jan 10, 2024

Seems to "cancel" the UI only, as the API building seems to continue to build. Click log immediately for empty log. Wait a few seconds then refresh log will show succeeded.

This is by design. Once the build process is commenced or queued it will continue. The cancel merely relinquishes the configurator to enable the user to exit the time out process.

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@blckmn @chmelevskij
Improved build request management (betaflight#3736)
0bdca6d 
* Improved build request management, enabling user to cancel and indicating whether processing has commenced.
* Adding timeout for the pending state (120 seconds) and minor refactor.
* Adding in some language versions for cancelled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@blckmn blckmn

Labels
RN: BUILD SYSTEM RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@blckmn @haslinghuis @McGiverGim @nerdCopter