Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EZLANDING debug field #3826

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

haslinghuis
Copy link
Member

Keep in sync with betaflight/betaflight#13411

@haslinghuis haslinghuis self-assigned this Mar 1, 2024

This comment has been minimized.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 2, 2024
@haslinghuis haslinghuis changed the title Add debug field Add EZLANDING debug field Mar 2, 2024
@HThuren HThuren self-requested a review March 2, 2024 20:07
Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no fuzz here

src/js/debug.js Outdated
@@ -754,6 +754,7 @@ const DEBUG = {
'debug[1]': 'Adjusted Throttle',
'debug[2]': 'Upper Limit',
'debug[3]': 'EZ Land Limit',
'debug[4]': 'Speed Limit',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to reasons (I was tired), I think the speed ended up at debug[5], and I think it might stay there, the stick deflection limit should probably have its own field too at some point in time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug[4] is now Stick limit, debug[5] is still Speed limit

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
100.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit e03d102 into betaflight:master Apr 3, 2024
8 checks passed
@haslinghuis haslinghuis deleted the add-debug-field branch April 3, 2024 20:59
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants