Fix compass calibration interval timeout #3865
Conversation
✅ Deploy Preview for origin-betaflight-configurator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix-mag-calibration
branch
from
ea4e3eb to
8c303fc
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix-mag-calibration
branch
from
8c303fc to
44e0deb
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix-mag-calibration
branch
from
44e0deb to
70a4d2f
Compare
|
|
Do you want to test this code? Here you have an automated build: |
|
Works perfectly! I had issues with my local build with GitHub... now I tested this branch, it's great! It would be even better if, on initiation (clicking the button), the text says, "Calibrate Magnetometer: waiting", or something like that. If no movement (ie if data collection never starts because movement threshold is not reached), then it times out at 15s and says "Calibrate Magnetometer: failed" in the button name, or something like that. One the other hand, if it works out, then once the cal is complete, we can say "Calibrate Magnetometer: success!" The button text could reset every time we enter the screen. |
|
Only have the CALIB armingDisableFlag as a measure to control the button. tCal in firmware would reset that flag. In my testing the button would resolve in 15 seconds when no movements were registered. |
|
@haslinghuis sorry my bad, initial test was accidentally with a build from Master. Now I tested this branch correctly, it works great. Approved. |
See also betaflight/betaflight#13487