Refactor to common page logic #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Oct 17, 2019
|
Gone as far as I can without feedback, ideas for further refactoring, etc. |
mikeller
previously approved these changes
Oct 20, 2019
There was a problem hiding this comment.
This looks good to me now, apart from needing a rebase.
@raphaelcoeffic: What are your thoughts?
frozenskys
force-pushed
the
refactor-to-screen-sizes
branch
from
956a887 to
000b0af
Compare
mikeller
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that OpenTx has aligned around screen size rather than device, it seems to make sense to refactor the BF lua script code in the same way.
I have tried to extract the page logic into device agnostic common pages, and the actual screen layout in to resolution dependent "Layouts." As part of this I have also moved some settings up to the radio level from the pages where it seemed to make sense.
Opening as a draft for comments...