Rates type support #365
Merged
Rates type support #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Awesome work @klutvott123 , thankyou! |
klutvott123
force-pushed
the
rates-type-support
branch
from
4ffb6d9 to
dd5c220
Compare
|
@asizon Thanks! 😸 |
mikeller
reviewed
Oct 8, 2020
src/SCRIPTS/BF/ui.lua
Outdated
| @@ -358,6 +358,7 @@ local function run_ui(event) | |||
| end | |||
| elseif pageState == pageStatus.editing then | |||
| if event == EVT_VIRTUAL_EXIT or event == EVT_VIRTUAL_ENTER then | |||
| pcall(Page.fields[currentField].postEdit, Page) | |||
There was a problem hiding this comment.
Why do we need the pcall() here?
There was a problem hiding this comment.
It just prevents the script from crashing if the field doesn't have postEdit.
Could have done this too
if Page.fields[currentField].postEdit then
Page.fields[currentField].postEdit(Page)
end
There was a problem hiding this comment.
I actually think this is a better way, as it is more specific. Otherwise any error that snuck into a postEdit() function could go undetected for a long time, causing debug nightmares.
There was a problem hiding this comment.
Good point! I'll change it
mikeller
previously approved these changes
Oct 8, 2020
|
Nicely done! |
Adds support for changing rates type.
klutvott123
force-pushed
the
rates-type-support
branch
from
dd5c220 to
4974c94
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for changing rates type.
Works like in the configurator. Changes labels, scaling, min, max, and applies default values for the selected rates type.
For testing: betaflight-tx-lua-scripts_1.5.0.zip