Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified tuning page #391

Merged
merged 1 commit into from
May 21, 2021

Conversation

klutvott123
Copy link
Member

@klutvott123 klutvott123 commented May 13, 2021

Simplified pid and filter tuning.

screenshot_x7_21-05-13_22-40-55
screenshot_x7_21-05-13_22-41-01

For testing:
betaflight-tx-lua-scripts_1.5.0.zip

Closes #355

Simplified pid and filter tuning.
@mikeller mikeller merged commit c2eb818 into betaflight:master May 21, 2021
@krisdover
Copy link

Thanks for implementing this @klutvott123, however when I tried to use the scripts from master the new simplified_tuning page didn't show up on my radio. I noticed it wasn't added to the list of scripts to be compiled in BF/COMPILE/scripts.lua, was this an oversight?

@klutvott123
Copy link
Member Author

@krisdover bin/build.sh has to be executed to build the scripts and generate the scripts.lua file. Try downloading the latest nightly build from here https://github.com/betaflight/betaflight-tx-lua-scripts-nightlies/releases and it should work

@klutvott123
Copy link
Member Author

Also keep in mind that you have to be running Betaflight 4.3 for this page to show up. There has been a lot of changes to simplified tuning and this version of simplified tuning is outdated if using the latest 4.3 master. The latest changes haven't been merged yet #399

@krisdover
Copy link

Ah, yes I just realised the dependency on MSP protocol changes in the Betaflight firmware. Makes sense now thanks. One other thing I noticed was the first line of the simplified_tuning.lua script references a file of a different name:

 local template = loadScript(radio.templateHome.."simplified_pids.lua")

Might not be an issue (as I'm not a lua developer) but just thought I'd point it out :)

Thanks again for adding this feature, it's something that I felt was lacking since I fell in love with the tuning slider functionality in BF 4.1 👍

@klutvott123
Copy link
Member Author

local template = loadScript(radio.templateHome.."simplified_pids.lua") this is a mistake. The template filename should match the name of the page filename. We're not using custom templates for any pages so this hasn't caused any problems yet, but thanks for pointing it out. I'll take care of it 👍

For earlier BF versions the tuning sliders were done in the configurator. In BF 4.3 it's done in the firmware itself and that's how we're able to do it in the lua scripts now.
if you decide to try out BF 4.3, I have just uploaded a test version of the lua scripts with updated simplified tuning support in this PR #399

@klutvott123 klutvott123 deleted the simplified-tuning branch November 26, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add the BF slider values into the BF Lua script
3 participants