Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSP protocol #409

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

klutvott123
Copy link
Member

@klutvott123 klutvott123 commented Dec 12, 2021

for compatibility with betaflight/betaflight#11112.

The changes are:

  • Reads version number from status byte
  • Updated error bit mask. It's now bit 7
  • Read command from payload based on version number
  • Check CRC only for old MSP implementation
  • Removed zero fill for outgoing buffer
  • Some cosmetics

These changes makes it work with betaflight/betaflight#11112 while still being compatible with the previous implementation. MSPv1 jumbo frames and MSPv2 is not implemented yet, but can be added when/if we need it. I have tested this with and without the PR, using TBS Tracer and Frsky Fport and can confirm that it works as it should.

For testing:
betaflight-tx-lua-scripts_1.5.0.zip

@klutvott123 klutvott123 added this to the 1.6 milestone Dec 13, 2021
@klutvott123 klutvott123 merged commit edfadc7 into betaflight:master Dec 14, 2021
@klutvott123 klutvott123 deleted the update-msp-protocol branch January 17, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants