Position OSD Elements via Script #463

druckgott · 2022-12-05T17:06:09Z

I added a new page where all osd elements are listet and you can select via the first filed by changing the number up and down each osd element.
On the lower area you can see the name of the osd element and more lower you can see the position value and the profil where this osd element is visible.

You can change the position and also the profil and then save the value and the osd will be updated.

src/SCRIPTS/BF/PAGES/pos_osd.lua

druckgott · 2022-12-05T20:44:02Z

I did something wrong I think, I want to remove all commits expect the last two how descriped here:
#457 (comment)
But anyting go wrong.
I change from the 9 commits listed only the 3 one I do not want to have to fixup and then I pushed again over cmd git: git push --force-with-lease
But then I see also old comits inside?! Do I have to change the git rebase -i HEAD~~9 to git rebase -i HEAD~~5 and then change pick to fixup only for the one I want to hold anymore?

haslinghuis · 2022-12-05T20:48:11Z

Please check: https://github.com/betaflight/betaflight/wiki/Betaflight-Contribution#squash-your-commits

src/SCRIPTS/BF/PAGES/pos_osd.lua

src/SCRIPTS/BF/pages.lua

klutvott123 · 2022-12-07T22:03:33Z

I'm trying this now, and I'm not sure I understand how it's supposed to work. I can't change anything. It goes through all retries and the changes won't take effect.

druckgott · 2022-12-08T06:32:57Z

The Adress you can change to select the osd element you want to change.
The you have to go down to the line where the on off points are if all 3 points are off you will not see the element in the osd
If one of it is one you can see the element in the osd, this the first number you can change the position, if you are if you then save the osd element should be on a mother position if you atere in the right osd page.
So my idea was at first only to move a element if you see on the field it's not fitting perfekt lx you like it and you have no pc here.

druckgott · 2022-12-08T07:32:24Z

Here is a Video
https://youtu.be/4ZpBPOYd2qk

druckgott · 2022-12-09T07:07:53Z

I'm trying this now, and I'm not sure I understand how it's supposed to work. I can't change anything. It goes through all retries and the changes won't take effect.

Did you see the video? What system do you have for me it works perfekt, I have a taranis x light pro.

klutvott123 · 2022-12-09T20:56:22Z

Yes, I saw the video. I have a taranis qx7. Tested with fport and tracer. FC config is minimal. Just rx and osd enabled. I can make changes in the configurator and they show up in the script. It may be that my test setup is a little too minimal.

druckgott · 2022-12-09T21:23:17Z

What I'm not sure if the addresses are always the same or if they depend what's aktivated for example gps, but I do not know how to read out the availible elements due to the config like the betaflight editor do. If anybody can help me there maybe that's better?!

src/SCRIPTS/BF/PAGES/pos_osd.lua

src/SCRIPTS/BF/pages.lua

klutvott123 · 2022-12-10T18:03:48Z

What I'm not sure if the addresses are always the same or if they depend what's aktivated for example gps, but I do not know how to read out the availible elements due to the config like the betaflight editor do. If anybody can help me there maybe that's better?!

They should be the same. I got it working here by clearing the values table before preparing the payload when saving. See one of the comments above for explanation.

klutvott123 · 2022-12-10T22:21:23Z

I'll just add that this doesn't work with ELRS because MSP_OSD_CONFIG results in a huge payload spread across more than 2 CRSF frames. Not much we can do about it here as it's a ELRS limitation.

druckgott · 2022-12-11T09:48:03Z

I did most changes expect this two:

Global Variable not fixed, because then on reload it do not work it did not have again the same selected osd element
Screen Value is needed because it needs >1 https://github.com/betaflight/betaflight/blob/b7b53399abd712476255c3b62099e04c65ba116d/src/main/msp/msp.c#L4155
--> I moved screen value to x and y -300 so it´s not visible for the user

src/SCRIPTS/BF/PAGES/pos_osd.lua

druckgott · 2022-12-14T11:59:41Z

I changed all the things, hopefully I get everything ;-). Thx for your good Ideas it helps me to improve my programming skills ;-).

src/SCRIPTS/BF/PAGES/pos_osd.lua

klutvott123 · 2022-12-19T13:23:11Z

Almost there. Just some minor things that need fixing.
There are probably more optimizations that could be done here with regard to memory use, but it's ok for now I think.

druckgott · 2022-12-19T15:09:14Z

hopefully all is ok now ;-)

klutvott123 · 2022-12-19T15:09:57Z

Looks good 🙂 Just need to squash/fixup to one commit now

druckgott · 2022-12-19T15:49:10Z

Hopefully all is fine now, I´m not shure if I did everything right, but I hope only on commit is visible with the right input.

klutvott123

Looks good to me 🙂

haslinghuis · 2022-12-19T18:29:27Z

src/SCRIPTS/BF/PAGES/pos_osd.lua

+        local fieldThirdProfile = bit32.band(bit32.rshift(profiles, 1), 1)
+        local fieldFourthProfile = bit32.band(bit32.rshift(profiles, 2), 1)
+        return fieldPos, fieldFirstProfile, fieldThirdProfile, fieldFourthProfile


Logic stays the same but guess:

FieldFourthProfile should be FieldThirdProfile
FieldThirdProfile should be FieldSecondProfile

lol good catch. 🥇
@druckgott Please fix 😁

I will fix tomorrow

It´s fixed

Add Page for Position OSD Elements (Betaflight 4.4 MSP) Add osd pos Page Update pos_osd.lua Update pages.lua Update pos_osd.lua

haslinghuis reviewed Dec 5, 2022

View reviewed changes