Add scale to ground speed for >= API 1.45 #466
Conversation
|
Did this change? Or was it always like that? |
src/SCRIPTS/BF/PAGES/rescue.lua
Outdated
| if apiVersion >= 1.45 then | ||
| fields[#fields + 1] = { t = "Ground Speed", x = x, y = inc.y(lineSpacing), sp = x + sp, min = 30, max = 3000, vals = { 7, 8 } } | ||
| else | ||
| fields[#fields + 1] = { t = "Ground Speed", x = x, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 3000, vals = { 7, 8 }, scale = 100 } | ||
| end |
There was a problem hiding this comment.
Did the min limit change? Hasn't it always been 0.3m/s? Are you sure you're scaling it for the right api version here?
There was a problem hiding this comment.
Min has changed. See below.
There was a problem hiding this comment.
It's still 0.3m/s in the configurator, but sure, we can do 0. Just need to decide if it's supposed to be in m/s for api version >= 1.45 or below
There was a problem hiding this comment.
@haslinghuis This has to be changed around. This adds the scaling for apiVersion < 1.45
|
Yes scale seem to be wrong before (in any case looking at https://github.com/betaflight/betaflight/pull/11834/files 😕 Might need to update the label: { "RETURN SPEED CM/S", OME_UINT16 | REBOOT_REQUIRED, NULL, &(OSD_UINT16_t){ &gpsRescueConfig_rescueGroundspeed, 0, 3000, 1 } }, |
I think the label should be consistent with the configurator label, and the number itself should be shown as in the configurator. This is the kind of bugs we get when labels aren't used. "needs coordination with betaflight configurator" lets us look at the milestone and pick up all the changes that have been made to user changeable parameters. Sure it might be that the person implementing the changes in firmware are doing the configurator PR as well, but still labels should be used. |
|
Configurator UI seems not have been updated ground speed. Last time it was updated: betaflight/betaflight-configurator#1946 |
|
@ctzsnooze - can you help us out here? |
haslinghuis
force-pushed
the
change-ground-speed
branch
from
a78f85b to
458dbab
Compare
haslinghuis
force-pushed
the
change-ground-speed
branch
from
458dbab to
9f07432
Compare
Fixes: #465