Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSP request for UBLOX SatInfo and disable SatInfo on ARMING. #13240

Merged
merged 6 commits into from
Dec 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 22, 2023

As configurator some times fails to get satellite info as it missed the opportunity we rather like to add a MSP request from client.

@haslinghuis haslinghuis added this to the 4.5 milestone Dec 22, 2023
@haslinghuis haslinghuis self-assigned this Dec 22, 2023
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13240 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis marked this pull request as draft December 22, 2023 23:19
@haslinghuis haslinghuis marked this pull request as ready for review December 23, 2023 00:19
@haslinghuis haslinghuis changed the title Add MSP request for GNSS Satellite info Add MSP request for UBLOX Satellite info Dec 23, 2023
@blckmn
Copy link
Member

blckmn commented Dec 23, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis modified the milestones: 4.5, 4.6 Dec 23, 2023
@haslinghuis haslinghuis force-pushed the add-msp-sat-info branch 2 times, most recently from a646531 to fb74f3c Compare December 23, 2023 19:03
@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 24, 2023

Tested - works GREAT! Much faster than before.

The only thing I haven't confirmed is that the sat info is not being sent when not connected to configurator. That requires parallel monitoring the output of the GPS module in pyGps or uCenter, and powering it up with Configurator not connected.

Two questions:

  • could there be some other MSP connection, other than Configurator, which could be active and initiate SatInfo messages when we don't want them - eg an MSP connected GPS itself, or an MSP connected HD goggles? Is this mechanism only initing SatInfo for Configurator alone?
  • if a user powers up with Lipo, and connects to Configurator to check sats, that will enable SatInfo. If they disconnect from Configurator, but keep the Lipo connected, will SatInfo continue to be sent, or will it stop when MSP is disconnected?

It is very important that SatInfo is not requested in flight, it results in a very big serial data load.

@Pancronos
Copy link

Tested - works GREAT! Much faster than before.

The only thing I haven't confirmed is that the sat info is not being sent when not connected to configurator. That requires parallel monitoring the output of the GPS module in pyGps or uCenter, and powering it up with Configurator not connected.

Two questions:

  • could there be some other MSP connection, other than Configurator, which could be active and initiate SatInfo messages when we don't want them - eg an MSP connected GPS itself, or an MSP connected HD goggles? Is this mechanism only initing SatInfo for Configurator alone?
  • if a user powers up with Lipo, and connects to Configurator to check sats, that will enable SatInfo. If they disconnect from Configurator, but keep the Lipo connected, will SatInfo continue to be sent, or will it stop when MSP is disconnected?

It is very important that SatInfo is not requested in flight, it results in a very big serial data load.

For your second question i think (for the little i understand code) is also checking the armed flag. So, in anycase, if you take off satinfo is disabled.

@haslinghuis haslinghuis modified the milestones: 4.6, 4.5 Dec 24, 2023
@haslinghuis haslinghuis force-pushed the add-msp-sat-info branch 2 times, most recently from 3c68853 to 9e0b5b7 Compare December 24, 2023 15:37
@haslinghuis
Copy link
Member Author

@ctzsnooze

Two questions:

could there be some other MSP connection, other than Configurator, which could be active and initiate SatInfo messages when we don't want them - eg an MSP connected GPS itself, or an MSP connected HD goggles? Is this mechanism only initing SatInfo for Configurator alone?

SatInfo will only be requested (enabled) when sending the MSP message on the gps tab in configurator.

if a user powers up with Lipo, and connects to Configurator to check sats, that will enable SatInfo. If they disconnect from Configurator, but keep the Lipo connected, will SatInfo continue to be sent, or will it stop when MSP is disconnected?

It is very important that SatInfo is not requested in flight, it results in a very big serial data load.

ARMING the quad disables SatInfo.

@haslinghuis haslinghuis force-pushed the add-msp-sat-info branch 2 times, most recently from 39d69a5 to e600b11 Compare December 24, 2023 16:28
@haslinghuis haslinghuis changed the title Add MSP request for UBLOX Satellite info Add MSP request for UBLOX SatInfo and disable SatInfo on ARMING. Dec 24, 2023
@haslinghuis haslinghuis marked this pull request as draft December 24, 2023 17:48
@haslinghuis haslinghuis marked this pull request as ready for review December 24, 2023 18:48
@blckmn blckmn merged commit 22ce586 into betaflight:master Dec 24, 2023
23 checks passed
@haslinghuis haslinghuis deleted the add-msp-sat-info branch December 24, 2023 23:50
freasy pushed a commit to freasy/betaflight that referenced this pull request Jan 22, 2024
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

6 participants