Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC API versionning #2116

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

PoC API versionning #2116

wants to merge 3 commits into from

Conversation

mxmeunier
Copy link
Collaborator

NE PAS MERGE

POC close #2003

export function authMocks(app: Express) {
/**
* Sessions
* TODO: is this really used ? in doc we should use app.use(passport.sessions()) to make use persistent login sessions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut mais on n'a pas forcément envie d'avoir des sessions persistantes

@@ -17,6 +53,7 @@ export function authMocks(app: Express) {
passwordField: "password",
},
async (email, password, done) => {
console.log("passport login middleware");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on veut pas le garder mais ok pour un poc. Je mets ça pour ne pas l'oublier

@@ -36,6 +74,7 @@ export function authMocks(app: Express) {
passReqToCallback: true,
},
async (req: Request, tokenPayload, done) => {
console.log("passport jwt middleware", tokenPayload, getJtwTokenFromRequest(req));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem log à ne pas garder à finalisation du poc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui j'ai pas tout clean pardon :p

packages/api/package.json Show resolved Hide resolved
@@ -67,11 +69,13 @@ export async function startServer(port = "8080", isTest = false) {

app.use(headersMiddleware);

// const router = express.Router();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit com

@VSerain
Copy link
Collaborator

VSerain commented Feb 8, 2024

Globalement ça me va !
J'ai juste un soucis avec le login quand on utilise la version par default
image

@VSerain
Copy link
Collaborator

VSerain commented Feb 8, 2024

Globalement ça me va ! J'ai juste un soucis avec le login quand on utilise la version par default image

Je peut m'en occuper demain si besoin

@mxmeunier
Copy link
Collaborator Author

Globalement ça me va ! J'ai juste un soucis avec le login quand on utilise la version par default image

Je peut m'en occuper demain si besoin

vas y fait toi plaisir !

@VSerain
Copy link
Collaborator

VSerain commented Feb 15, 2024

Globalement ça me va ! J'ai juste un soucis avec le login quand on utilise la version par default image

Je peut m'en occuper demain si besoin

C'est régler !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voir comment gérer les différentes versions dans les contrôleurs TSOA
3 participants