-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC API versionning #2116
base: develop
Are you sure you want to change the base?
PoC API versionning #2116
Conversation
export function authMocks(app: Express) { | ||
/** | ||
* Sessions | ||
* TODO: is this really used ? in doc we should use app.use(passport.sessions()) to make use persistent login sessions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On peut mais on n'a pas forcément envie d'avoir des sessions persistantes
@@ -17,6 +53,7 @@ export function authMocks(app: Express) { | |||
passwordField: "password", | |||
}, | |||
async (email, password, done) => { | |||
console.log("passport login middleware"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on veut pas le garder mais ok pour un poc. Je mets ça pour ne pas l'oublier
@@ -36,6 +74,7 @@ export function authMocks(app: Express) { | |||
passReqToCallback: true, | |||
}, | |||
async (req: Request, tokenPayload, done) => { | |||
console.log("passport jwt middleware", tokenPayload, getJtwTokenFromRequest(req)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem log à ne pas garder à finalisation du poc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oui j'ai pas tout clean pardon :p
@@ -67,11 +69,13 @@ export async function startServer(port = "8080", isTest = false) { | |||
|
|||
app.use(headersMiddleware); | |||
|
|||
// const router = express.Router(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petit com
de816f5
to
9041c14
Compare
9c3188b
to
61639e3
Compare
NE PAS MERGE
POC close #2003