Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update application-attachment to typescript #793

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Update application-attachment to typescript #793

merged 3 commits into from
Oct 28, 2020

Conversation

mdulac
Copy link
Contributor

@mdulac mdulac commented Oct 23, 2020

No description provided.

@jdauphant jdauphant temporarily deployed to aplus-demo-task-upgrade-wg7jok October 23, 2020 17:29 Inactive
@jdauphant jdauphant temporarily deployed to aplus-demo-task-upgrade-wg7jok October 28, 2020 14:28 Inactive
@niladic
Copy link
Collaborator

niladic commented Oct 28, 2020

Ça a jamais marché sur IE11, j'ai corrigé le polyfill manquant
Screen Shot 2020-10-28 at 15 47 32

@niladic niladic marked this pull request as ready for review October 28, 2020 15:45
niladic
niladic approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@niladic niladic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait une correction pour IE11, la fonctionnalité n'a en fait jamais marché parce que IE11 ne supporte pas NodeList.forEach.

@niladic niladic merged commit 355e6cc into master Oct 28, 2020
@niladic niladic deleted the task/upgrade-javascript-to-typescript branch October 28, 2020 20:32
@niladic niladic mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladic niladic niladic approved these changes

@jdauphant jdauphant Awaiting requested review from jdauphant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdulac @niladic @jdauphant