Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extract-history #9

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Add extract-history #9

merged 1 commit into from
Feb 1, 2025

Conversation

fflorent
Copy link
Collaborator

See the README file.

Copy link
Collaborator

@hexaltation hexaltation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

LGTM

But i'll rename the script something like extract-grist-history.sh

Quite not short but have the advantage to be discoverable by a find . -name *grist*.sh
I'll not block if you disagree :)

@fflorent
Copy link
Collaborator Author

fflorent commented Feb 1, 2025

Thanks for your review!

It's a bit inconsistent, but most of the existing scripts are already named without mentioning grist. They are already included in a repository named grist.

What I usually do is to add a symlink of these scripts in a $HOME/bin folder. Therefore I can have them in my $PATH.

In your case, I tend to suggest to name these scripts of the form you would like. Does it make sense to you?

@hexaltation
Copy link
Collaborator

As said I will not block. :)
Even if I disagree.

Namespaces are one honking great idea -- let's do more of those!
Extract from *The Zen of Python, by Tim Peters*

@hexaltation hexaltation merged commit bb3542d into main Feb 1, 2025
6 of 7 checks passed
@fflorent fflorent deleted the parse-history branch February 1, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants