Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Nouveau simulateur Réduction Générale #3100

Merged
merged 15 commits into from
Oct 18, 2024

Conversation

liliced
Copy link
Contributor

@liliced liliced commented Aug 27, 2024

No description provided.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for nostalgic-mahavira-52b682 canceled.

Name Link
🔨 Latest commit 19b32e4
🔍 Latest deploy log https://app.netlify.com/sites/nostalgic-mahavira-52b682/deploys/670e3832f9db010008b81159

Copy link

♿ Checklist accessibilité :

Quelques points à vérifier pour maintenir une bonne accessibilité du site :

  • les labels des boutons et des liens sont descriptifs
  • un aria-label est ajouté pour préciser l'action d'un bouton ou d'un lien pour les lecteurs d'écran
  • les couleurs du texte est suffisamment constratée par rapport à la couleur de background
  • la fonctionnalité ajoutée est utilisable en navigant au clavier et avec un lecteur d'écran
  • les changements de contexte sont évités ou au minimum annoncés

@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 14:48 Inactive
@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 14:48 Inactive
Copy link

github-actions bot commented Aug 27, 2024

@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch 2 times, most recently from 56b7ec7 to 6414b33 Compare August 27, 2024 14:58
@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 15:04 Inactive
@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 15:05 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from 6414b33 to 4ce1f89 Compare August 27, 2024 15:08
@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 15:12 Inactive
@github-actions github-actions bot temporarily deployed to 3100 August 27, 2024 15:12 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from 4ce1f89 to 003e48c Compare August 30, 2024 14:23
Copy link
Collaborator

@VeroniqueR75 VeroniqueR75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erreurs constatées :

  • L'actualisation de la RGCP par rapport au salaire brut saisi ne s'effectue pas systématiquement (sur Edge principalement)
  • Idem lorsque j'efface ma saisie bouton "Effacer les réponses", les valeurs du précédent calcul RGCP reste affiché

Proposition :

  • Ajouter une info-bulle à côté du champ "réduction générale" et mettre les liens vers les sites d'information comme dans la documentation

@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from 003e48c to e38b909 Compare September 3, 2024 08:51
@liliced
Copy link
Contributor Author

liliced commented Sep 3, 2024

Les erreurs constatées ci-dessus ne sont pas liée au simulateur mais sont dues à un bug général des simulateurs lors de la navigation dans la documentation.

L'info-bulle a été remplacée par un lien cliquable.

@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch 2 times, most recently from 8324d3e to f4441d5 Compare September 3, 2024 09:00
@github-actions github-actions bot temporarily deployed to 3100 September 3, 2024 09:04 Inactive
@github-actions github-actions bot temporarily deployed to 3100 September 3, 2024 09:05 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from f4441d5 to ce2b2ab Compare September 3, 2024 09:23
@github-actions github-actions bot temporarily deployed to 3100 September 3, 2024 09:32 Inactive
@github-actions github-actions bot temporarily deployed to 3100 September 3, 2024 09:32 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch 4 times, most recently from 979fa87 to bbf26fa Compare September 10, 2024 10:10
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from 5c12d1b to bb58cf6 Compare September 30, 2024 08:35
@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 08:40 Inactive
@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 08:40 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from bb58cf6 to dfe295b Compare September 30, 2024 09:06
@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 09:11 Inactive
@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 09:11 Inactive
Copy link
Collaborator

@VeroniqueR75 VeroniqueR75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lorsque je mets un montant annuel de rénumération inférieur à 1,6 fois le Smic mensuel j'ai quand même le message de dépassement qui s'affiche.

@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 14:46 Inactive
@github-actions github-actions bot temporarily deployed to 3100 September 30, 2024 14:46 Inactive
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from 4099b60 to d919db4 Compare October 15, 2024 09:34
@liliced liliced force-pushed the feat/3086-simulateur-reduction-generale branch from d919db4 to 19b32e4 Compare October 15, 2024 09:38
@github-actions github-actions bot temporarily deployed to 3100 October 15, 2024 09:44 Inactive
@liliced liliced merged commit 8ff36d6 into master Oct 18, 2024
41 checks passed
@liliced liliced deleted the feat/3086-simulateur-reduction-generale branch October 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RGCP] Calculer la réduction générale annuelle ou pour un mois (cas nominal)
3 participants