Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration instructions confirmation compte au DSFR #4936

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Migration instructions confirmation compte au DSFR #4936

merged 2 commits into from
Jan 2, 2025

Conversation

AntoineGirard
Copy link
Member

@AntoineGirard AntoineGirard commented Dec 31, 2024 •
edited
Loading

Contexte

On continue à migrer les éléments non DSFR vers le DSFR.

Solution

  • On retire l’usage des boutons ici car nous n’avons pas le droit d’utiliser des boutons pour des liens de navigation externe.

Captures d'écran

Avant Après
image image

@AntoineGirard AntoineGirard force-pushed the agd/remove-font-awesome-registration-confirm-instruction branch from 912f398 to aaeb3fe Compare January 2, 2025 14:25
@AntoineGirard AntoineGirard marked this pull request as ready for review January 2, 2025 14:35
adipasquale
adipasquale approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@adipasquale adipasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 parfait merci

app/views/users/registrations/pending.html.slim Outdated Show resolved Hide resolved
config/locales/devise.fr.yml Outdated Show resolved Hide resolved
@AntoineGirard AntoineGirard force-pushed the agd/remove-font-awesome-registration-confirm-instruction branch from aaeb3fe to e10c056 Compare January 2, 2025 15:40
@AntoineGirard AntoineGirard enabled auto-merge (squash) January 2, 2025 15:40
@AntoineGirard AntoineGirard merged commit 45d5d31 into production Jan 2, 2025
15 checks passed
@AntoineGirard AntoineGirard deleted the agd/remove-font-awesome-registration-confirm-instruction branch January 2, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adipasquale adipasquale adipasquale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
RDV Service Public
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineGirard @adipasquale