[Perf] Précharger les associations de la liste de RDVs de l'API #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adipasquale
approved these changes
Jan 6, 2025
|
C'est malin, on dirait que plus personne n'appelle cet endpoint depuis cette optimisation (aucune donnée sur Skylight). 👀 |
|
Ah, on a enfin eu un nouveau pic de requêtes (187 requêtes, wow) pendant le weekend (voir screenshot en description) : on passe à 300 ms en moyenne par requête au lieu de 1300 ms ! ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai remarqué sur Skylight que tous nos appels vers l'API de liste des RDVs prennent entre 1100-1500ms, alors qu'il s'agit d'une page de 100 RDVs.
Certes le blueprint inclus beaucoup d'associations (les users sont inclus un fois à travers les participations et une second fois à la racine...), mais la raison principale est les requêtes N+1.
Testé en local, ce préchargement devrait dramatiquement réduire le temps d'exécution de cet endpoint.
Avant (6 janvier 2025)
https://www.skylight.io/app/applications/RgR7i58P67xN/recent/6h/endpoints/Api::V1::RdvsController%23index?responseType=json
Après (11 janvier 2025)