Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI.ObjectModels.SharedModels.AssistantResponse missing temperature, top_p #657

Closed
jmuller3 opened this issue Oct 25, 2024 · 1 comment
Labels
enhancement New feature or request Ready for next version This issue solved and waiting for next release
Milestone

Comments

@jmuller3
Copy link
Contributor

Describe the bug
temperature and top_p props are not present in result model from AssistantRetrieve

Your code piece

  • code flow attempts to spawn a clone of an existing assistant for modifications, but needed props are not available from the AssistantResponse
    AssistantResponse existing = await _service(serviceParams).AssistantRetrieve(assistantID); AssistantResponse response = await _service(serviceParams).AssistantCreate(new AssistantCreateRequest() { Description = $"cloned from: {existing.Id} at " + DateTime.UtcNow.ToString("g"), Instructions = existing.Instructions, Model = existing.Model, Name = "Cloned - " + existing.Name, ToolResources=existing.ToolResources, Metadata = new Dictionary<string, string>() { { "Parent", existing.Id }}_, Temperature= **existing.Temperature**, TopP = **existing.TopP**_ }); return response;

Result
no result currently, can't pass along the props because I can't access them

Expected behavior
AssistantResponse supports all props available in AssistantCreate/Modify

Screenshots
n/a

Desktop (please complete the following information):
Windows, C#, 8.7.2

Additional context
N/A

jmuller3 added a commit to jmuller3/openai that referenced this issue Oct 28, 2024
@kayhantolga kayhantolga added enhancement New feature or request good first issue Good for newcomers labels Oct 29, 2024
kayhantolga added a commit that referenced this issue Nov 13, 2024
#657 add AssistantResponse missing props -> temperature, top_p
kayhantolga pushed a commit to alanextar/openai that referenced this issue Nov 13, 2024
kayhantolga pushed a commit to stephentoub/openai that referenced this issue Nov 13, 2024
@kayhantolga kayhantolga added Ready for next version This issue solved and waiting for next release and removed good first issue Good for newcomers labels Nov 13, 2024
@kayhantolga kayhantolga added this to the 8.10.0 milestone Nov 13, 2024
@kayhantolga
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for next version This issue solved and waiting for next release
Projects
None yet
Development

No branches or pull requests

2 participants