Add DotNet 8.0 Support #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BroMarduk
commented
Dec 6, 2023
BroMarduk
commented
- Added DotNet 8.0 Libraries
- Rewrote some functions to support previous versions of frameworks for Utilites (support back to NetStandard2.0)
BroMarduk
commented
Dec 6, 2023
BroMarduk
commented
Dec 6, 2023
| @@ -1,4 +1,6 @@ | |||
| using System.Collections; | |||
| #if NET6_0_OR_GREATER | |||
There was a problem hiding this comment.
This utility will not run with .NetStandard 2.0 without more fixes so excluding it from utilities for now.
BroMarduk
commented
Dec 6, 2023
BroMarduk
commented
Dec 6, 2023
| @@ -153,7 +153,7 @@ public static List<FunctionDefinition> GetFunctionDefinitions(Type type) | |||
| throw new InvalidFunctionCallException($"Method '{functionCall.Name}' on type '{obj.GetType()}' not found"); | |||
| } | |||
|
|
|||
| if (!methodInfo.ReturnType.IsAssignableTo(typeof(T))) | |||
| if (!typeof(T).IsAssignableFrom(methodInfo.ReturnType)) | |||
There was a problem hiding this comment.
IsAssignableTo not supported in .NetStandard 2.0 so reversed it to IsAssignableFrom for support.
|
I have reverted the changes in the utilization library. The utilization library does not support, and will not support, legacy versions, including .NET 6 and .NET 7. |
kayhantolga
added
the
Ready for next version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.