Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add String_Split function if not exist #17

Merged
merged 1 commit into from Sep 16, 2021
Merged

feat: add String_Split function if not exist #17

merged 1 commit into from Sep 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2021

Create function Split_String if not exist.

Fix #7

magne
magne approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@magne magne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the complete test suite, and the PR does not seem to affect those. I've not tested this with a database where the String_Split function is not present, but at least this shouldn't affect other users.

@magne magne merged commit d6539ce into betr-io:master Sep 16, 2021
@ghost
Copy link
Author

ghost commented Sep 16, 2021

I have tested on a base where it is not present and it is functional. I was careful not to affect other users.

@rlaveycal rlaveycal mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create user: mssql: Incorrect syntax near the keyword 'with'
1 participant
@magne