Skip to content

Commit

Permalink
Removed (limited) dojo dependencies for has, lang, and event.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Wilcox committed Jun 27, 2012
1 parent c92cd5f commit 51ac68e
Showing 1 changed file with 19 additions and 18 deletions.
37 changes: 19 additions & 18 deletions on.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
define([
'dojo/on',
'dojo/aspect',
'dojo/sniff',
'dojo/_base/lang',
'dojo/_base/event'
], function(dojoOn, aspect, has, lang, event){
'./has',
'./lang'
], function(dojoOn, aspect, has, lang){
// summary:
// The export of this module is a function, which also has other
// methods attached to it. This is a major combination of dojo.on and
Expand Down Expand Up @@ -103,13 +102,13 @@ define([
scope = ctx;
ctx = global;
}
fn = fn || lang.hitch(ctx, scope);
fn = fn || lang.bind(ctx, scope);

if(typeof target == 'string'){
// race condition, no access to dx-alias/dom
target = document.getElementById(target);

}else if(!target.addEventListener && !target.attachEvent){ // need better checking here (emitters, objects with addEventListener)
}else if(!target.addEventListener && !target.attachEvent){
// ASPECT
// an object, not a node
var paused = 0;
Expand Down Expand Up @@ -191,7 +190,7 @@ define([
};

on.press = function(node, ctx, method, arg, group){
var fn = lang.hitch(ctx, method);
var fn = lang.bind(ctx, method);
var passArg = arg;
var tmr, offHandle, downHandle;
var tch = 0; //bv.supports.touch();
Expand Down Expand Up @@ -226,7 +225,7 @@ define([
// summary:
// Connect then disconnect after it's been called once.
//
var fn = lang.hitch(ctx, method);
var fn = lang.bind(ctx, method);
var handle = on(target, event, function(){
handle.remove();
fn.apply(null, arguments);
Expand All @@ -247,16 +246,18 @@ define([
}

on.selector = dojoOn.selector;
on.stopEvent = event.stop; // move to dx-event?

// on.group = {
// pause
// resume
// add
// }
//
// on.group.pause(groupId);


on.stopEvent = function(evt){
evt = evt || window.event;
if(!evt) return false;
if(evt.preventDefault){
evt.preventDefault();
evt.stopPropagation();
}else{
evt.cancelBubble = true;
evt.returnValue = false;
}
return false;
};
return on;
});

0 comments on commit 51ac68e

Please sign in to comment.