Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 RFC: Chord Style Directive #352

Closed
isaiahdahl opened this issue Nov 22, 2022 · 0 comments · Fixed by #421
Closed

💡 RFC: Chord Style Directive #352

isaiahdahl opened this issue Nov 22, 2022 · 0 comments · Fixed by #421

Comments

@isaiahdahl
Copy link

Background & Motivation

We need a directive that allows us to set the chord style independent from the key.

Even though when a chart is in numbers or numerals, technically that chart can be used in any key. We still want to be able to use the store the key directive because there could be other things that need to know the key of the song. Like a track or pad.

The key selector in the studio editor will look something like this:
CleanShot 2022-11-22 at 09 38 26

Where Chord Style is something you can select independent from key.

In PraiseCharts. We just treat Numbers & Numerals as a key and have it as an option in the key dropdown. But continuing with that solution would limit us down the road if we wanted to add things to the studio that need a key.

Proposed Solution

Possible solutions

title: Rattle!
key: Eb

Intro (5x)
Eb5 / / / | / / / / |

Verse 1
Eb                   Ebsus         Eb
Saturday was silent, surely it was through
const song = song.setChordStyle('numbers');
title: Rattle!
key: Eb
chord_style: numbers

Intro (5x)
15 / / / | / / / / |

Verse 1
1                    1sus          1
Saturday was silent, surely it was through

I'd want it so that chord_style is one of those metadata's that you don't really change manually in the text, and through a function which would then set the chord_style. Like how you wouldn't change the key of the song by changing the key metadata, but by using a transpose or key selector button which then in turn changes/updates the metadata.

Calling setChordStyle() would set the metadata for chord_style and 'transpose' the whole chart into a numbers chart. BUt this could happen independent of the key: directive.

martijnversluis added a commit that referenced this issue Oct 30, 2023
martijnversluis added a commit that referenced this issue Oct 30, 2023
* Add extensive test cases for renderChord()

* Open debugger in default system browser

* Implement chord_style directive

Resolves #352
martijnversluis added a commit that referenced this issue Nov 14, 2023
* Add extensive test cases for renderChord()

* Open debugger in default system browser

* Implement chord_style directive

Resolves #352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant