Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Chords over lyrics #77

Closed
wants to merge 4 commits into from
Closed

WIP: Chords over lyrics #77

wants to merge 4 commits into from

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Sep 7, 2022

This branch will add support to "chords over lyrics" to the editor.

Nothing to see yet…

image

@bkeepers bkeepers mentioned this pull request Sep 13, 2022
@bkeepers bkeepers force-pushed the chords-over-lyrics-story branch from 2510180 to d07ab64 Compare September 13, 2022 18:26
@@ -1,18 +1,24 @@
@dialects { pro, crd }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaiahdahl any suggestions on naming these? I chose crd because that's the file extension that I've seen used for songsheets that use chords over lyrics.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PraiseCharts we've always referred to it as "Chords Over Words" in the current editor mode dropdowns and surveys etc. But "Chords Over Words" and "Chords Over Lyrics" are pretty much synonymous, It's just what we've picked to be consistent.

That translated to us just recently naming the new ChordSheetJS parser the ChordsOverWordsParser, and we will be creating the ChordsOverWordsFormatter.

All that to say, is there a reason we want short, extension style dialet labels?

What about:

@dialects { chordPro, chordsOverWords }

I tend to prefer clarity over shortness when it's not so obvious what the shortform means. But is writing it out like that gonna be too long for cleanliness?

@isaiahdahl
Copy link
Collaborator

Some guy greated a great playground for Lezer. Will be massively helpful for this project

CleanShot 2022-11-04 at 09 38 55

https://github.com/dralletje/Notebook-Experiments/tree/main/lezer-playground

@isaiahdahl
Copy link
Collaborator

Closing as support for Chords Over Words was achieved with #251

@isaiahdahl isaiahdahl closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants