Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some web examples fail to render #384

Closed
aaronsantiago opened this issue Jun 16, 2022 · 3 comments
Closed

Some web examples fail to render #384

aaronsantiago opened this issue Jun 16, 2022 · 3 comments
Labels
A-Examples C-Bug A problem with the code that runs the site

Comments

@aaronsantiago
Copy link

Currently for some examples like: https://bevyengine.org/examples/2d/sprite-sheet/ and https://bevyengine.org/examples/stress-tests/bevymark/ the output is only grey.

Output:
unknown (2)

Console:
unknown (1)

I've tested this with the same result in Edge, Chrome, and Firefox on Windows, and Chrome and Firefox on OSX.
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site A-Examples labels Jun 16, 2022
@mockersf
Copy link
Member

related to #355
@doup or @ickk any ideas why the custom fetch is failing now?

@mockersf
Copy link
Member

https://crates.io/crates/wasm-bindgen was updated 2 days ago and probably changed the js generated, and

bevy-website/generate-wasm-examples/generate_wasm_examples.sh

Lines 44 to 48 in 75acb73

sed -i.bak \
-e 's/function init(input) {/function init(customFetch, input) { customFetch = customFetch || fetch;/' \
-e 's/input = fetch(/input = customFetch(/' \
-e 's/getObject(arg0).fetch(/customFetch(/' \
../../content/examples/$category_slug/$example_slug/$example.js
probably fail to update it correctly

@IceSentry IceSentry mentioned this issue Jun 16, 2022
Closed
bors bot pushed a commit that referenced this issue Jun 17, 2022
@IceSentry
fix customFetch not found (#385)
167581b 
An update to wasm_bindgen changed how the file is generated.

This update adds customFetch to the new getImports function.

I didn't manage to reproduce it locally, but it does work when I do the change manually in the dev tools

fixes #384
bors bot pushed a commit that referenced this issue Jun 17, 2022
@IceSentry
fix customFetch not found (#385)
70408c8 
An update to wasm_bindgen changed how the file is generated.

This update adds customFetch to the new getImports function.

I didn't manage to reproduce it locally, but it does work when I do the change manually in the dev tools

fixes #384
@bors bors bot closed this as completed in d4a8c7d Jun 17, 2022
@mockersf
Copy link
Member

issue is now fixed for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Examples C-Bug A problem with the code that runs the site
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - fix customFetch not found IceSentry/bevy-website
3 participants
@alice-i-cecile @mockersf @aaronsantiago