-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration Guide 0.13 - "Unload render assets from RAM" is outdated #984
Comments
That is |
Just a note: it's Also, the |
Fixed on #987 |
This fix was made to a branch, not to |
Unload render assets from RAM migration guide is outdated due to RenderAssetPersistencePolicy → RenderAssetUsages.
I could just make a PR to replace
RenderAssetPersistencePolicy::Keep
withRenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
as per #11399, but I don't know if it will make sense:cpu_persistent_access
. These assets will be removed fromAssets<Mesh>
andAssets<Image>
onceRenderAssets<Mesh>
andRenderAssets<Image>
contain the GPU versions of these assets, in order to reduce memory usage. If you require access to the asset data from the CPU in future frames after the GLTF asset has been loaded, modify all dependentMesh
andImage
assets and setcpu_persistent_access
toRenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
.Mesh
now requires a newcpu_persistent_access
field. Set it toRenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
to mimic the previous behavior.Image
now requires a newcpu_persistent_access
field. Set it toRenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
to mimic the previous behavior.MorphTargetImage::new()
now requires a newcpu_persistent_access
parameter. Set it toRenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
to mimic the previous behavior.DynamicTextureAtlasBuilder::add_texture()
now requires that theTextureAtlas
you pass has anImage
withcpu_persistent_access: RenderAssetUsage::MAIN_WORLD | RenderAssetUsage::RENDER_WORLD
. Ensure you construct the image properly for the texture atlas.RenderAsset
trait has significantly changed, and requires adapting your existing implementations.Clone
.ExtractedAsset
associated type has been removed (the type itself is now extracted).prepare_asset()
is slightly differentpersistence_policy()
method is now required (returnRenderAssetUsage::RENDER_WORLD
to match the previous behavior).The text was updated successfully, but these errors were encountered: