Migration Guide: 0.4 to 0.5 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration guide for systemparams and insert()
memoryruins
suggested changes
Mar 10, 2021
| } | ||
|
|
||
| // 0.5 | ||
| fn foo(r1_thru_3: (Res<Thing1>, Res<Thing2>, Res<Thing3>), r4: Res<Thing4>, ... r15: Res<Thing15>) { |
There was a problem hiding this comment.
Suggested change
| fn foo(r1_thru_3: (Res<Thing1>, Res<Thing2>, Res<Thing3>), r4: Res<Thing4>, ... r15: Res<Thing15>) { | |
| fn foo(r1_thru_3: (Res<Thing1>, Res<Thing2>, Res<Thing3>), r4: Res<Thing4>, ... r12: Res<Thing12>) { |
There was a problem hiding this comment.
oh, I was too quick to comment. I see now how its using the nested for the first three ^^
There was a problem hiding this comment.
Maybe it would be good to pattern match the first argument to help with noticing the change?
Suggested change
| fn foo(r1_thru_3: (Res<Thing1>, Res<Thing2>, Res<Thing3>), r4: Res<Thing4>, ... r15: Res<Thing15>) { | |
| fn foo((r1, r2, r3): (Res<Thing1>, Res<Thing2>, Res<Thing3>), r4: Res<Thing4>, ... r15: Res<Thing15>) { |
|
How could I contribute to this? Am I supposed to make PRs against the branch of carts fork? |
Add points 4&5 about Events API and add_resource => insert_resource
Documentation Improvements
Address migration point 30
Section 7: Timer and Stopwatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial migration guide page. This is intended to be a collaborative effort. To contribute, leave a comment on 0.4 to 0.5 migration guide issue claiming one or more unclaimed items, then create a pull request to this branch.
Each migration item should have a description of the change (with rationale if you anticipate a negative response), descriptions of breakage symptoms (when that is relevant and non-obvious), and small before/after code snippets where relevant.
Todos: