Skip to content

Commit 2d830ee

Browse files
Remove ron re-export
1 parent 6c56e2f commit 2d830ee

File tree

7 files changed

+16
-13
lines changed

7 files changed

+16
-13
lines changed

crates/bevy_asset/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ pub use reflect::*;
204204
pub use render_asset::*;
205205
pub use server::*;
206206

207-
/// Rusty Object Notation, a crate used to serialize and deserialize bevy assets.
208-
pub use ron;
209207
pub use uuid;
210208

211209
use crate::{

crates/bevy_scene/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ keywords = ["bevy"]
1111
[features]
1212
default = ["serialize"]
1313
serialize = [
14+
"dep:ron",
1415
"dep:serde",
1516
"uuid/serde",
1617
"bevy_ecs/serialize",
@@ -32,6 +33,7 @@ bevy_platform = { path = "../bevy_platform", version = "0.18.0-dev", default-fea
3233
] }
3334

3435
# other
36+
ron = { version = "0.11", default-features = false, optional = true }
3537
serde = { version = "1.0", features = ["derive"], optional = true }
3638
uuid = { version = "1.13.1", features = ["v4"] }
3739
thiserror = { version = "2", default-features = false }

crates/bevy_scene/src/dynamic_scene.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@ use bevy_ecs::component::ComponentCloneBehavior;
1313
use bevy_ecs::relationship::RelationshipHookMode;
1414

1515
#[cfg(feature = "serialize")]
16-
use {
17-
crate::{ron, serde::SceneSerializer},
18-
bevy_reflect::TypeRegistry,
19-
serde::Serialize,
20-
};
16+
use {crate::serde::SceneSerializer, bevy_reflect::TypeRegistry, ron, serde::Serialize};
2117

2218
/// A collection of serializable resources and dynamic entities.
2319
///

crates/bevy_scene/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ mod scene_spawner;
2424
#[cfg(feature = "serialize")]
2525
pub mod serde;
2626

27-
/// Rusty Object Notation, a crate used to serialize and deserialize bevy scenes.
28-
pub use bevy_asset::ron;
29-
3027
pub use components::*;
3128
pub use dynamic_scene::*;
3229
pub use dynamic_scene_builder::*;

crates/bevy_scene/src/scene_loader.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
use crate::ron;
21
use bevy_ecs::{
32
reflect::AppTypeRegistry,
43
world::{FromWorld, World},
54
};
65
use bevy_reflect::TypeRegistryArc;
6+
use ron;
77
use thiserror::Error;
88

99
#[cfg(feature = "serialize")]

crates/bevy_scene/src/serde.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ pub const ENTITY_FIELD_COMPONENTS: &str = "components";
5252
/// let scene_serializer = SceneSerializer::new(&scene, &registry);
5353
///
5454
/// // Serialize through any serde-compatible Serializer
55-
/// let ron_string = bevy_scene::ron::ser::to_string(&scene_serializer);
55+
/// let ron_string = ron::ser::to_string(&scene_serializer);
5656
/// ```
5757
pub struct SceneSerializer<'a> {
5858
/// The scene to serialize.
@@ -510,7 +510,6 @@ impl<'a, 'de> Visitor<'de> for SceneMapVisitor<'a> {
510510
#[cfg(test)]
511511
mod tests {
512512
use crate::{
513-
ron,
514513
serde::{SceneDeserializer, SceneSerializer},
515514
DynamicScene, DynamicSceneBuilder,
516515
};
@@ -522,6 +521,7 @@ mod tests {
522521
world::FromWorld,
523522
};
524523
use bevy_reflect::{Reflect, ReflectDeserialize, ReflectSerialize};
524+
use ron;
525525
use serde::{de::DeserializeSeed, Deserialize, Serialize};
526526
use std::io::BufReader;
527527

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
title: Remove ron re-export from bevy_scene and bevy_asset
3+
pull_requests: [21611]
4+
---
5+
6+
The `ron` crate is no longer re-exported from `bevy_scene` or `bevy_asset`. This was done to reduce naming conflicts and improve API clarity.
7+
8+
If you were importing `ron` through `bevy_scene` or `bevy_asset`, you should now add `ron` as a direct dependency to your project.
9+
10+
This change only affects code that was explicitly importing the `ron` module. All internal scene serialization and deserialization functionality remains unchanged.

0 commit comments

Comments
 (0)