rename to EarthlikeAtmosphere

Author: ecoskey

crates/bevy_pbr/src/atmosphere/mod.rs

@@ -114,15 +114,10 @@ impl Plugin for AtmospherePlugin {
         .add_systems(Update, prepare_atmosphere_probe_components);
 
         let world = app.world_mut();
-        let earth_atmosphere = world
+        let earthlike_medium = world
             .resource_mut::<Assets<ScatteringMedium>>()
-            .add(ScatteringMedium::earth_atmosphere());
-        world.insert_resource(EarthAtmosphere(Atmosphere {
-            bottom_radius: 6_360_000.0,
-            top_radius: 6_460_000.0,
-            ground_albedo: Vec3::splat(0.3),
-            medium: earth_atmosphere,
-        }));
+            .add(ScatteringMedium::earthlike(256, 256));
+        world.insert_resource(EarthlikeAtmosphere(Atmosphere::earthlike(earthlike_medium)));
     }
 
     fn finish(&self, app: &mut App) {
@@ -208,9 +203,9 @@ impl Plugin for AtmospherePlugin {
 }
 
 #[derive(Resource)]
-pub struct EarthAtmosphere(Atmosphere);
+pub struct EarthlikeAtmosphere(Atmosphere);
 
-impl EarthAtmosphere {
+impl EarthlikeAtmosphere {
     pub fn get(&self) -> Atmosphere {
         self.0.clone()
     }
@@ -242,6 +237,20 @@ pub struct Atmosphere {
     pub medium: Handle<ScatteringMedium>,
 }
 
+impl Atmosphere {
+    pub fn earthlike(medium: Handle<ScatteringMedium>) -> Self {
+        const EARTH_BOTTOM_RADIUS: f32 = 6_360_000.0;
+        const EARTH_TOP_RADIUS: f32 = 6_460_000.0;
+        const EARTH_ALBEDO: Vec3 = Vec3::splat(0.3);
+        Self {
+            bottom_radius: EARTH_BOTTOM_RADIUS,
+            top_radius: EARTH_TOP_RADIUS,
+            ground_albedo: EARTH_ALBEDO,
+            medium,
+        }
+    }
+}
+
 impl ExtractComponent for Atmosphere {
     type QueryData = Read<Atmosphere>;
 

crates/bevy_pbr/src/medium.rs

@@ -117,10 +117,10 @@ impl ScatteringMedium {
     }
 
     /// Returns a scattering medium representing an earthlike atmosphere.
-    pub fn earth_atmosphere() -> Self {
+    pub fn earthlike(falloff_resolution: u32, phase_resolution: u32) -> Self {
         Self::new(
-            256,
-            256,
+            falloff_resolution,
+            phase_resolution,
             [
                 ScatteringTerm {
                     absorption: Vec3::ZERO,
@@ -145,7 +145,7 @@ impl ScatteringMedium {
                 },
             ],
         )
-        .with_label("earth_atmosphere")
+        .with_label("earthlike_atmosphere")
     }
 }
 

examples/3d/atmosphere.rs

@@ -6,7 +6,7 @@ use bevy::{
     camera::Exposure,
     core_pipeline::tonemapping::Tonemapping,
     light::{light_consts::lux, AtmosphereEnvironmentMapLight, CascadeShadowConfigBuilder},
-    pbr::{AtmosphereSettings, EarthAtmosphere},
+    pbr::{AtmosphereSettings, EarthlikeAtmosphere},
     post_process::bloom::Bloom,
     prelude::*,
 };
@@ -19,7 +19,7 @@ fn main() {
         .run();
 }
 
-fn setup_camera_fog(mut commands: Commands, earth_atmosphere: Res<EarthAtmosphere>) {
+fn setup_camera_fog(mut commands: Commands, earth_atmosphere: Res<EarthlikeAtmosphere>) {
     commands.spawn((
         Camera3d::default(),
         Transform::from_xyz(-1.2, 0.15, 0.0).looking_at(Vec3::Y * 0.1, Vec3::Y),