appease clippy

Author: jrobsonchase

crates/bevy_animation/src/lib.rs

@@ -25,9 +25,7 @@ use std::{
 use bevy_app::{App, Plugin, PostUpdate};
 use bevy_asset::{Asset, AssetApp, Assets, Handle};
 use bevy_core::Name;
-use bevy_ecs::{
-    entity::MapEntities, prelude::*, reflect::ReflectMapEntities, world::EntityMutExcept,
-};
+use bevy_ecs::{prelude::*, reflect::ReflectMapEntities, world::EntityMutExcept};
 use bevy_math::FloatExt;
 use bevy_reflect::{
     prelude::ReflectDefault, utility::NonGenericTypeInfoCell, ApplyError, DynamicStruct, FieldIter,

crates/bevy_ecs/src/entity/map_entities.rs

@@ -38,7 +38,7 @@ where
     T: IterEntities,
 {
     fn map_entities<F: FnMut(Entity)>(&self, f: F) {
-        self.iter_entities().for_each(f)
+        self.iter_entities().for_each(f);
     }
 }
 
@@ -47,7 +47,7 @@ where
     T: MapEntities + IterEntitiesMut,
 {
     fn map_entities_mut<F: FnMut(&mut Entity)>(&mut self, f: F) {
-        self.iter_entities_mut().for_each(f)
+        self.iter_entities_mut().for_each(f);
     }
 }
 

crates/bevy_ecs/src/reflect/map_entities.rs

@@ -1,6 +1,6 @@
 use crate::{
     component::Component,
-    entity::{Entity, EntityHashMap, EntityMapper, MapEntities, MapEntitiesMut, SceneEntityMapper},
+    entity::{Entity, EntityHashMap, EntityMapper, MapEntitiesMut, SceneEntityMapper},
     world::World,
 };
 use bevy_reflect::{FromReflect, FromType, PartialReflect};
@@ -64,7 +64,7 @@ impl ReflectMapEntities {
     /// A general method for applying an operation to all entities in a
     /// reflected component.
     pub fn map_entities(&self, component: &dyn PartialReflect, f: &mut dyn FnMut(Entity)) {
-        (self.map_entities)(component, f)
+        (self.map_entities)(component, f);
     }
 
     /// A general method for applying an operation that may modify entities in a
@@ -74,7 +74,7 @@ impl ReflectMapEntities {
         component: &mut dyn PartialReflect,
         f: &mut dyn FnMut(&mut Entity),
     ) {
-        (self.map_entities_mut)(component, f)
+        (self.map_entities_mut)(component, f);
     }
 }
 

crates/bevy_hierarchy/src/components/children.rs

@@ -1,11 +1,6 @@
 #[cfg(feature = "reflect")]
 use bevy_ecs::reflect::{ReflectComponent, ReflectFromWorld, ReflectMapEntities};
-use bevy_ecs::{
-    component::Component,
-    entity::{Entity, MapEntitiesMut},
-    prelude::FromWorld,
-    world::World,
-};
+use bevy_ecs::{component::Component, entity::Entity, prelude::FromWorld, world::World};
 use core::slice;
 use smallvec::SmallVec;
 use std::ops::Deref;
@@ -168,6 +163,8 @@ impl<'a> IntoIterator for &'a Children {
 
 #[cfg(test)]
 mod test {
+    use bevy_ecs::entity::MapEntitiesMut;
+
     use super::*;
 
     fn assert_impls_map_entities_mut<M: MapEntitiesMut>() {}

crates/bevy_render/src/mesh/mesh/skinning.rs

@@ -1,9 +1,6 @@
 use bevy_asset::{Asset, Handle};
 use bevy_ecs::{
-    component::Component,
-    entity::{Entity, EntityMapper, MapEntities},
-    prelude::ReflectComponent,
-    reflect::ReflectMapEntities,
+    component::Component, entity::Entity, prelude::ReflectComponent, reflect::ReflectMapEntities,
 };
 use bevy_math::Mat4;
 use bevy_reflect::prelude::*;

crates/bevy_scene/src/dynamic_scene.rs

@@ -212,7 +212,7 @@ mod tests {
 
     use bevy_ecs::{
         component::Component,
-        entity::{Entity, EntityHashMap, EntityMapper, IterEntities, IterEntitiesMut, MapEntities},
+        entity::{Entity, EntityHashMap, IterEntities, IterEntitiesMut},
         reflect::{
             AppTypeRegistry, ReflectComponent, ReflectMapEntities, ReflectMapEntitiesResource,
             ReflectResource,

crates/bevy_scene/src/serde.rs

@@ -515,7 +515,7 @@ mod tests {
         DynamicScene, DynamicSceneBuilder,
     };
     use bevy_ecs::{
-        entity::{Entity, EntityHashMap, EntityMapper, MapEntities},
+        entity::{Entity, EntityHashMap},
         prelude::{Component, ReflectComponent, ReflectResource, Resource, World},
         query::{With, Without},
         reflect::{AppTypeRegistry, ReflectMapEntities},

crates/bevy_window/src/window.rs

@@ -1,7 +1,7 @@
-use std::{iter, num::NonZero, option};
+use std::{num::NonZero, option};
 
 use bevy_ecs::{
-    entity::{Entity, EntityMapper, MapEntities},
+    entity::Entity,
     prelude::{Component, ReflectComponent},
 };
 use bevy_math::{DVec2, IVec2, UVec2, Vec2};
@@ -1230,11 +1230,11 @@ mod tests {
 
     use super::*;
 
-    // Compile-time assertion that a type implementes MapEntitiesMut
+    // Compile-time assertion that a type implements MapEntitiesMut
     fn impl_map_entities_mut<M: MapEntitiesMut>() {}
 
     // Ensure that WidowRef implements MapEntitiesMut
-    #[allow(dead_code)]
+    #[test]
     fn window_impls_map_entities_mut() {
         impl_map_entities_mut::<WindowRef>();
     }