Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM build is failing for projects using Bevy 0.12 (including the Bevy wasm example) #10417

Closed
forbjok opened this issue Nov 6, 2023 · 9 comments
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior

Comments

@forbjok
Copy link
Contributor

forbjok commented Nov 6, 2023

Bevy version

0.12.0

[Optional] Relevant system information

cargo 1.73.0 (9c4383fb5 2023-08-26)
Windows 10 Pro 22H2 build 19045.3570

What you did

Try to build a Bevy 0.12.0 project for WASM.

What went wrong

The build fails with this error.
image

This happens both with my game project, and when trying to build the WASM example in the Bevy repository.

@forbjok forbjok added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Nov 6, 2023
@rparrett
Copy link
Contributor

rparrett commented Nov 6, 2023

This is #10412. Running cargo update should fix the issue.

@forbjok
Copy link
Contributor Author

forbjok commented Nov 6, 2023

This is #10412. Running cargo update should fix the issue.

Nope, just tested again after running cargo update, and it's still producing the same error.

@mockersf
Copy link
Member

mockersf commented Nov 6, 2023

cargo update --package blocking --precise 1.4.1

for now should make it work

@forbjok
Copy link
Contributor Author

forbjok commented Nov 6, 2023

cargo update --package blocking --precise 1.4.1

for now should make it work

Yep, that seems to work as a workaround.

@mockersf
Copy link
Member

mockersf commented Nov 6, 2023

smol-rs/blocking#52

@Irvingouj
Copy link

Irvingouj commented Nov 7, 2023

Blocking should never be used in any asynchronous context, this will never be tolerated in browsers (wasm32-unknown-unknown).

@nicopap nicopap added A-Build-System Related to build systems or continuous integration P-Critical This must be fixed immediately or contributors or users will be severely impacted and removed S-Needs-Triage This issue needs to be labelled labels Nov 7, 2023
@nicopap
Copy link
Contributor

nicopap commented Nov 7, 2023

It is currently impossible to merge any PR due to this issue. Marking the issue as critical.

@nicopap
Copy link
Contributor

nicopap commented Nov 16, 2023

Resolved now?

@nicopap nicopap removed the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Nov 16, 2023
@forbjok
Copy link
Contributor Author

forbjok commented Nov 21, 2023

Resolved now?

Yes, the issue seems to have gone away now.

@nicopap nicopap closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

5 participants