Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reimplement reflection probes #11315

Closed
alice-i-cecile opened this issue Jan 12, 2024 · 1 comment
Closed

Fix and reimplement reflection probes #11315

alice-i-cecile opened this issue Jan 12, 2024 · 1 comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible P-High This is particularly urgent, and deserves immediate attention
Milestone

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 12, 2024

          Fix for reflection probes should be pretty simple. I believe we just need to add a check if the render device supports the texture binding array feature, rather than a conditional cfg for non wasm platforms.

Originally posted by @JMS55 in #11307 (comment)

Unfortunately #10057 broke several platforms. Revert the revert, then add a commit to fix the broken platforms on top.

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Jan 12, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 12, 2024
@JMS55 JMS55 added the P-High This is particularly urgent, and deserves immediate attention label Jan 15, 2024
@JMS55
Copy link
Contributor

JMS55 commented Jan 20, 2024

Closed by #11366

@JMS55 JMS55 closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Development

No branches or pull requests

2 participants