Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wedge to primitive shapes #11786

Closed
lynn-lumen opened this issue Feb 9, 2024 · 1 comment
Closed

Add Wedge to primitive shapes #11786

lynn-lumen opened this issue Feb 9, 2024 · 1 comment
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@lynn-lumen
Copy link
Contributor

What problem does this solve or what need does it fill?

The RFC mentions a few primitive shapes like Wedge or Cone that are not included in bevy_math::primitives or that do not implement bevy_render::mesh::Meshable and cannot be used as shapes for Meshes.

  • Cone is implemented in bevy_math and can be used as a gizmo but not as a Mesh primitive.
  • Wedge is not implemented anywhere.

What solution would you like?

Add Wedge to bevy_math and implement Meshable for both.

What alternative(s) have you considered?

Implement Meshable for Cone and don't add Wedge at all.

Additional context

I think Ramp would be a better name for the Wedge shape as described in the RFC mentioned above because not every wedge is a ramp and not every ramp is a wedge.

For example in this image:
Screenshot 2024-02-09 at 03 20 25

  • The left shape is a valid ramp, but not a wedge (This shape conforms to what is described in the RFC)
  • The right shape is a valid wedge but not a ramp.
@lynn-lumen lynn-lumen added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 9, 2024
@alice-i-cecile alice-i-cecile added A-Math Fundamental domain-agnostic mathematical operations D-Trivial Nice and easy! A great choice to get started with Bevy and removed S-Needs-Triage This issue needs to be labelled labels Feb 9, 2024
@lynn-lumen
Copy link
Contributor Author

This is included in the Extrusion<Triangle2d> implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

No branches or pull requests

2 participants