Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bevy plugin dependency crashes #12782

Open
s-puig opened this issue Mar 29, 2024 · 1 comment
Open

Fix bevy plugin dependency crashes #12782

s-puig opened this issue Mar 29, 2024 · 1 comment
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior

Comments

@s-puig
Copy link
Contributor

s-puig commented Mar 29, 2024

What problem does this solve or what need does it fill?

You would expect that the following: app.add_plugins(DefaultPlugins.build().disable::<SpritePlugin>()) would disable 2D and every plugin feature that depends on it (gizmos, ui, etc..), but most Bevy plugins rely on feature flags instead. This makes disabling most plugins to crash the app.

What solution would you like?

  • Add plugin checks (is_plugin_added) and allow plugins to specify their plugin dependencies so App can automatically order them.

What alternative(s) have you considered?

  • Short term, we could add plugin checks and order them manually on Default/MinimalPlugins
@s-puig s-puig added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Mar 29, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-App Bevy apps and plugins and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Mar 29, 2024
@alice-i-cecile
Copy link
Member

Related to the ideas in #1255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

2 participants