Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending a GamepadButtonChangedEvent but Axis<GamepadButton> is not changed #13195

Open
Shute052 opened this issue May 3, 2024 · 1 comment
Open

Sending a GamepadButtonChangedEvent but Axis<GamepadButton> is not changed #13195

Shute052 opened this issue May 3, 2024 · 1 comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Investigation This issue requires detective work to figure out what's going wrong X-Uncontroversial This work is generally agreed upon

Comments

@Shute052
Copy link

Shute052 commented May 3, 2024 •
edited
Loading

Bevy version

What you did

Sending a GamepadButtonChangedEvent to modify the state of Axis<GamepadButton>.

What went wrong

Nothing changed.
@Shute052 Shute052 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 3, 2024
@Shute052 Shute052 changed the title Sending a GamepadButtonChangedEvent but Axis<GamepadButton> not changed Sending a GamepadButtonChangedEvent but Axis<GamepadButton> is not changed May 3, 2024
@Shute052 Shute052 mentioned this issue May 3, 2024
Open
@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more S-Needs-Investigation This issue requires detective work to figure out what's going wrong X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels May 3, 2024
@s-puig
Copy link
Contributor

s-puig commented May 4, 2024

I fixed this in #12770.

An easy fix would be writing them back (bypassing change detection) in gamepad_button_event_system

IMO, regardless of this bug, bevy_gilrs should be changed to send raw events and let bevy_input handle the filtering.

@s-puig s-puig mentioned this issue Sep 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Investigation This issue requires detective work to figure out what's going wrong X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alice-i-cecile @Shute052 @s-puig