Bevy 0.14 adds some very expensive debug assertions somewhere

[SludgePhD]

Bevy version

0.14.0

What you did

In bevy 0.13, my application runs at 60 FPS in a debug build with a Cargo profile override like this:

[profile.dev.package."*"]
opt-level = 3

In bevy 0.14, the same application struggles to hit 20 FPS with the same build configuration. Adding debug-assertions = false to the build config brings the lost performance back.

What went wrong

While debug assertions are often useful, these seem a bit too heavy to justify their inclusion (especially given that even all the checked arithmetic in the whole dependency tree doesn't destroy performance this badly).

This may be caused by wgpu, I have not investigated this issue.

[alice-i-cecile]

We should fix this :) Bisecting or a minimal reproduction are the most useful next steps here.

[alice-i-cecile]

According to gfx-rs/wgpu#5756, this looks to have been introduced in the wgpu 0.20 bump in #13186. Can you bisect before and after this?

[janhohenheim]

@SludgePhD does the following line fix the issue?

[profile.dev.package.wgpu-types]
debug-assertions = false

[AyeTbk]

I noticed the same problem on my end, and applying @janhohenheim suggestion makes a massive difference (~60 FPS without it, ~460 FPS with it).

[SludgePhD]

Yes, that fixes the issue

[janhohenheim]

@cwfitzgerald just reopened the linked issue (thanks!)
Marking this as blocked since it's a WGPU problem.